kentcdodds/jest-glamor-react

Use placeholder classnames

kentcdodds opened this issue · 4 comments

See this. Doing this could significantly improve code reviews and avoid this problem:

screen shot 2017-06-26 at 4 20 55 pm

Notice that none of those rules changed. So it's just noise in the diff. Would be much nicer to only see the diff where it changed.

Though, that could present other problems. Like what happens when I add another styled component into the mix? That would bump all of the placeholders up. Would that be all that bad though 🤔. Perhaps @MicheleBertoli can share some thoughts

Anyone can feel free to help with this. Please just follow the contributing guidelines

I would like to take a stab at it.

Is this the first timer friendly issue?

I don't think I'd say it's really first-timer friendly, but you could definitely give it a try! this might be inspiring...