kentcdodds/kcd-scripts

lintstagedrc.js failes on Windows

JeffBaumgardt opened this issue · 1 comments

JeffBaumgardt commented
  • node version: 10.10.0
  • npm (or yarn) version: 6.0.0

Relevant code or config

npm run precommit

Problem description:

I'm working on a fork of kcd-scripts for my own company's purposes and while testing the lintstagedrc.js file failes on Windows. Probably has to do with #8 or is very similar. I also noticed this when working on React-Testing-Library when I went to commit, again lintstagedrc.js fails.

Unfortunately I'm not versed enough in the fs and path operators to figure out how to change \ for /. Unless we write a dirty method to check for win32 and do a global replace on the path string, tranding slashes. But I don't know what other problems might arise from that.

JeffBaumgardt commented

Probably a separate issue and but I get the same popup Windows Script Host complaining about dist\run-script.js on line 3. Reading the outputted source shows that to be the require('path') which makes no sense. Unfortunately windows isn't good here at troubleshooting errors.