kermitt2/entity-fishing

Japanese language alpha 2 misconifgured

ChielWH opened this issue · 3 comments

Hi!

When trying to use Term look-up in Japanese, I get the following error:

Error encountered while requesting the server.
{ "message": "The language specified is not supported or not valid. " }

I think the source of this error is that jp is used for abbreviating Japanese in the supported languages for term look-up:

var supportedLanguages = ["en", "es", "it", "fr", "de", "ar", "zh", "jp", "ru", "pt", "fa"];

While in the rest of the application it is abbreviated with ja (also on wikipedia itself). A test supporting this is to do a text disambiguation and fill in both the abbreviations in the lang field; providing ja yields expected results, providing jp yields the same error as shown above. I've tested this both on https://cloud.science-miner.com/nerd/ and on a local deployment, results are the same.

Besides this issue, props on this amazing project! We are getting great value from it!

Hi @ChielWH !

Thank you very much for the issue and the explanations, and sorry for the misspelling in the front-end file.

This is corrected with ef92268

Great! Thanks for the quick response.