kevincobain2000/gobrew

gobrew self-update always updates

Closed this issue · 5 comments

Previously when running gobrew self-update the tool would check for updates and if found would update the tool, otherwise it would report no update available and that you are already up to date.

Currently when running the above command the tool always seems to download and report 'Upgrade successful' even though no new version has been posted.

Can you please investigate?

Expected behaviour is to run this command and if an update is available then download and upgrade, otherwise do not download approx 6Mb unnecessarily.

Kind regards

lol, yea you are right.

probably next weekend :)

Implementation in the code is fine, there was a version mismatch on release.
I have pushed (forced) the tag v1.8.5 again.

Fixed

╭─pulkit.kathuria@JP-GCJKVGQK0G ~/git/re ‹master›
╰─$ gobrew self-update
Downloading 100% |███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| (6.0/6.0 MB, 2.8 MB/s)
Upgrade successful
╰─$ gobrew version
[INFO] gobrew version is 1.8.5

╭─pulkit.kathuria@JP-GCJKVGQK0G ~/git/re ‹master›
╰─$ gobrew self-update
[INFO] your version is already newest

Wonderful. Awesome tool. Use it daily. Don't let it go away!