kevinkhill/lavacharts

Use of <script type="text/javascript"> not right according to validator.w3.org

hugovoerman opened this issue · 1 comments

What Version?

3.1.11

Issue

In lavacharts/src/Javascript/ScriptManager.php

on line 45 the statement: const JS_OPEN = '<script type="text/javascript">';

I assume this is the opening of all JavaScript.

According to W3 this should only be: const JS_OPEN = '<script>';

Testing on https://validator.w3.org/ gives a message like:

Warning: The type attribute is unnecessary for JavaScript resources.

From line 781, column 1; to line 781, column 31

v>↩↩<script type="text/javascript">↩!func

Is it an idea to change the definition of this const as described above?

seems simple enough, submit a pull request? I'll merge that no problem.