kevinresol/react-native-sound-recorder

Unnecessary READ and WRITE permissions

kayzenkayzen opened this issue · 8 comments

kayzenkayzen commented

I am seeing that depending on the directory that is being used to save the file, it is not always necessary to have read and write permissions.

For example if we are saved in PATH_CACHE ( getCacheDir() )

This says the Android documentation:

Apps require no extra permissions to read or write to the returned path since this path lives in their private storage.

kevinresol commented

Does this lib even request any permissions?

irothenbaum commented

Yes, it does request permissions (confirmed on Android). And I can confirm that with microphone permissions allowed, and using PATH_CACHE, it still requests file storage.

kayzenkayzen commented

Does this lib even request any permissions?

Since the last release, yes!

kevinresol commented

Perhaps we should revert #28. I prefer requesting permissions manually in js (e.g. with react-native-permissions)

kayzenkayzen commented

I think it would be better to let the developer ask for the necessary permissions according to their recording configuration.

kevinresol commented

It had been my intention from the beginning. It was my mistake to merge #28.

kevinresol commented

Can anyone PR a fix?