kevinwucodes/gmail-quick-links

Compact layout vertically

Closed this issue · 5 comments

nrichards commented

Thank you for the killer Chrome Extension.

I'm wondering what you think about altering the layout, to make it more compact?

quick-links-compact

  • Moving the "Add Quick Link" DIV into the title label's
  • Shorten to just "Add"
nrichards commented

I am a noob web dev but please see the above PR - untested!

kevinwucodes commented

Hey @nrichards , thanks for the PR! I think this looks great! Before I accept the PR, could you rename the CSS attributes so that they're compatible with React?

Meaning, "align-items" becomes "alignItems"; "justify-content" becomes "justifyContent", etc.

nrichards commented

Heyo @kevinwucodes - glad it is to your liking :)

Renaming now ... is this commit correctly conforming the identifier naming to React-style?

New DIFF: https://github.com/kevinwucodes/gmail-quick-links/pull/25/files

kevinwucodes commented

merged

nrichards commented

Thanks Kevin :)