kevlened/fireway

Allow for extra files

Closed this issue · 4 comments

It would be really great if fireway didn't throw when encountering files that didn't meet the migration filename spec. This would allow for configuration files and helpers relevant to migrations to co-exist in the migrations folder.
Maybe just return null like when the filename doesn't comply with semver.

throw new Error(`This filename doesn't match the required format: ${filename}`);

Skipping files that don't meet the filename spec is a silent failure. When you have hundreds of migration files, it can become tedious to figure out if your migration ran just to discover a typo. I ran into this, which is why it's the default.

Does an option to skip filename validation solve your problem?

I suppose it's pretty uncommon to mess up v[semver]. You're right that skipping anything that doesn't match just that prefix would solve most of the issues. Works for me.

I do understand the case for typos, that would definitely be a chore. Skipping non-v[semver] is a good option!

Added in 0.3.2