keylime/rust-keylime

Warn if certificates in trusted_client_ca are not readable

THS-on opened this issue · 2 comments

It seems that this just silently not loads the certificate:

for cert in ca_certs {
mtls_store_builder
.add_cert(cert)
.map_err(|source| CryptoError::X509StoreBuilderError{
message: "failed to add certificate to X509 trusted certificate store".into(),
source,
})?;
}

The culprit is not the part of the code you pointed out: it properly raises the error when the certificate fails to load. The problem is on its caller, which is probably ignoring the error.

This will probably be fixed once I finish the error handling overhaul I'm currently working on.

@ansasaki ah I see thanks for taking a deeper look.

This will probably be fixed once I finish the error handling overhaul I'm currently working on.

Awesome thank you!