bug(nrc.en.mtnt): `we're` not offered as a suggestion for `were`
Closed this issue · 5 comments
I think this still needs to remain open for @jahorton to confirm this is resolved:
With a context of "were", I get 3 suggestions:
"were" (frequency 5309)
"weren't" (frequency 385)
"werent" (frequency 16)"we're" has a frequency of 927 so I would expect it to appear
On my alpha build of Keyman for Android, I'm still not getting "we're" as a suggestion.
Originally posted by @darcywong00 in #143 (comment)
Reproduced in Keyman 17.0.219-alpha
Inspecting the generated suggestions: it generally comes in as suggestion rank 6 - the apostrophe being missing comes at a high cost to the suggestion's probability. It'll should be available on the upgraded suggestion banner (#7934), at least.
I suggest that we elide apostrophe in the searchtermtokey function 😁 -- for this model
In case it takes a while to come back to...
-- for this model
Because a number of languages use apostrophes as literal letters, it's best not to erase them as a language-independent/model-independent default. We can definitely tweak the search-term function to make it a model-specific behavior, though.
Inspecting the generated suggestions: it generally comes in as suggestion rank 6 - the apostrophe being missing comes at a high cost to the suggestion's probability. It'll should be available on the upgraded suggestion banner (#7934), at least.
Re-ran on Keyman for Android 17.0.281-beta that includes the upgraded suggestion banner.
"we're" is down to number 7 now...
