khmyznikov/pwa-install

URL parameter support

cillian-cwb opened this issue · 5 comments

cillian-cwb commented

Hello.

I have now great control over what I need in pwa-install. Great work @khmyznikov. What it is really needed, is the bundle to support URL parameters. Auto detection work perfectly but it lacks URL parameter support.

I hope you find it to implement it shortly. Thank you.

khmyznikov commented

@cillian-cwb Hi! Can you describe more what do you mean, how it should work. I don't think I understand.

cillian-cwb commented

@cillian-cwb Hi! Can you describe more what do you mean, how it should work. I don't think I understand.

Ok. My project can override LocaleID with URL Parameters. For my case, '&language=en-GB', '&language=nb-NO', '&language=es-ES', &language=de-DE' and '&language=fr-FR'. So adding one of these parameters at the end of the URL overrides LocaleID and sets it accordingly.

khmyznikov commented

@cillian-cwb the component works with the language from the user's browser. It should be the same, to show the instruction properly. We had this discussion before and ended with conclusion what's the right way. #43

cillian-cwb commented

It works with auto detection yes. But not URL parameters.

Check yourself: https://khmyznikov.com/pwa-install&language=en-GB

khmyznikov commented

Ingen tilpasning for språk er støttet. Fordi brukergrensesnittet til komponenten skal være det samme som brukergrensesnittet til nettleseren.