khoih-prog/MySQL_MariaDB_Generic

suggest replacing all files xxxx_Impl.h by xxxx.cpp

pabloandresm opened this issue · 10 comments

pabloandresm commented

May I suggest suggest replacing all files xxxx_Impl.h by xxxx.cpp?

Having all code in .h header files creates linking errors if you "#include <MySQL_Generic>" from different .cpp modules of the same project, because the linker will find several times functions with the same name.

Having a proper .h corresponding to a proper .cpp, you can include the .h several times from everywhere without causing lining problems.

It happened to me.

Just a suggestion.

khoih-prog commented

Have a look at

  1. HOWTO Fix Multiple Definitions Linker Error or similar issues.
  2. Different behaviour using the src_cpp or src_h lib #80

I forget to convert this to h-only library with example similar to multiFileProject how to deal with the issue.

Will publish new release to deal with this, but never going back to .cpp-style, unless absolutely necessary.

pabloandresm commented

thank you for that info.
I ll read those links.
thanks

khoih-prog commented

Hi @pabloandresm

The new MySQL_MariaDB_Generic releases v1.7.0 has just been published. Your contribution is noted in Contributions and Thanks

Please test one of the new examples, such as multiFileProject_Ethernet, to see how to do for multiple-file projects to avoid Multiple Definitions Linker Error

Best Regards,

PS:

I'm excited and so busy to follow up with your suggestions, but still wish you provide many more ;-))

Releases v1.7.0

  1. Convert to h-only style
  2. Add multiFileProject examples to demo for multiple-file projects
pabloandresm commented

thank you very much.

I will try to keep up with the suggestions and fixes.

Are you going to publish it soon? so I can install it via Arduino.

Let me try the 1.7.0 and stress it and I will let you know.

thank you very much

khoih-prog commented

Already published v1.7.0. You can install from Arduino or PlatformIO now.

pabloandresm commented

strange.....arduino shows me the latest one as 1.6.1, and not the 1.7.0

khoih-prog commented

It takes some time to propagate to Library Manager (some hours ??). You can download directly from the GitHub, then unzip.

PS:

You have a good talent to finding bugs, especially using your stress tests. I wish you can use that to spots the bugs in my other libraries.

pabloandresm commented

yes, sure. Which other libraries you need to test?

one detail I forgot to mention.....since 1.6.0, when I update this library on Arduino IDE, it asks me if I want to update just this library or the dependencies also (it shows me a list of 5 dependency libraries). If I choose all dependencies, it successfully updates ONLY this library and fails with an error. Maybe this is caused by some dependency you marked that are ment to be for platformio?

I will screenshot it next time.

khoih-prog commented

If I choose all dependencies, it successfully updates ONLY this library and fails with an error.

Because this library is written to support too many boards, shields, libraries, architectures and platforms, I have to add all of them to the list. Many users complaint long ago if not. So better extra than nothing.

Sometimes, the Arduino IDE and/or PIO is not intelligent enough to select the correct libraries for that architectures / platform.

So, you have to manually install the necessary libraries, at least you know the list.

khoih-prog commented

yes, sure. Which other libraries you need to test?

You can see my full list of 130+ libraries in KH Libraries

Just jump into any library you're interested and possibly will use in your project, then click Homepage to jump to GitHub to download / test. All are in Arduino IDE Library Manager as well and you can use the name to install.

Selection_116