khoulihan/gopher-render

Top & bottom "margins" are excessive

Closed this issue · 2 comments

khoulihan commented

Because all elements are currently adding lines above and below, the margins between blocks are excessive by default. Couple of possible solutions:

  1. Pick a direction and have elements apply their desired margin in that direction only. Probably would have this be below, so paragraphs would just have a margin below, but none above. Headers could apply one above and one below to get a nice space to separate sections.
  2. Add spaces based on the relationships between siblings. Quite a bit more complicated this, though.
khoulihan commented

Maybe they're not that bad actually, I like the big spaces between the paragraphs. The thing to change would be that the headers are closer to the sections that preceed them than the ones they relate to.

khoulihan commented

The switch to markdown output by default largely resolves this.