kieler/klayjs-d3

Doesn't work with current version of d3

Closed this issue · 2 comments

v1r0x commented

Hi,
I decided to switch from manual downloading libs to bower. I only added klayjs-d3 as dependency in my bower.json file. This downloads klayjs and d3 as dependency, but it seems that klayjs-d3 depends on an older version of d3.

Error: d3.rebind is not a function
b@../bower_components/klayjs-d3/dist/klayjs-d3.min.js:2:3131
a.d3kgraph@.../bower_components/klayjs-d3/dist/klayjs-d3.min.js:2:3231
$scope.initD3Graph@.../controllers/mapCtrl.js:490:29

Line 490 in my js file is

klay.d3kgraph()

It used to work with version 3.5.17 of d3 and the same klayjs versions and code as well.

Current versions:
klayjs: 0.4.1 build 201604131004
klayjs-d3: version 0.3.5 build 201604271204
d3: 4.2.8

uruuru commented

I fixed the d3 version to ^3.5.0, which should resolve your issue. It looks like d3 v4.x got refactored to use ES modules.

v1r0x commented

It's working again. Thanks!