kikito/tween.lua

Should tweens be local?

mebens opened this issue · 7 comments

mebens commented

Should the tweens table be a local, since it's label under the comment "private stuff"?

kikito commented

Hi there!

I had to make the tweens variable global just so that I could make some bug hunting (using inspect, actually) and then I forgot.

Anyway, I've fixed this and re-released v1.0, giving you credit (the commit message said fixes issue #1 instead of #2, bah).

Thanks for reporting this!

mebens commented

Ha ha, good stuff!

mebens commented

Oh by the way, how did you get GitHub to actually display me on the commit?

kikito commented

I use the --author flag when I do the commit:

git commit -m 'my commit message' --author 'your name <your@email.com>'

github detects the author and includes you in the list of authors magically.

mebens commented

Oh cool, I just learnt something new. Someday I should get round to learning a bit more than the Git fundamentals, lol.

So would it be --author 'Michael Ebens <my@email.com>' or --author 'BlackBulletIV <my@email.com>'? I'm guessing the first.

kikito commented

You guessed right, it's the first. I'm not sure whether github uses the name, the email or a combination of both for showing the picture.

mebens commented

It would be the e-mail; there could be multiple Michael Ebens' on GitHub (unlikely though, my name is very unique it seems).