killbill/killbill-commons

Address Spotbugs errors

Closed this issue · 2 comments

pierre commented
  1. Enforce the Spotbugs checks by enabling the property check.fail-spotbugs
  2. Remove the various check.spotbugs-exclude-filter-file properties and associated spotbugs-exclude.xml files
  3. Remove the @SuppressFBWarnings annotations
  4. Address the errors.
xsalefter commented

PR will be per-module basis, and this is the order:

[INFO] killbill-commons
[INFO] Kill Bill Clock classes and interfaces for killbill and killbill-commons
[INFO] Kill Bill library of java.util.concurrent wrappers
[INFO] Kill Bill config-magic
[INFO] Kill Bill library of embedded dbs
[INFO] Kill Bill library of embedded dbs: common
[INFO] Kill Bill library of embedded dbs: H2
[INFO] Kill Bill library that provides utility methods for core Java(tm) classes
[INFO] Kill Bill library of embedded dbs: MySQL
[INFO] Kill Bill library of embedded dbs: PostgreSQL
[INFO] killbill-metrics-api
[INFO] Kill Bill utilities for jdbi
[INFO] Kill Bill distributed locking library
[INFO] Kill Bill Persistent Queues (bus/notificationQ)
[INFO] killbill-metrics
[INFO] Kill Bill utilities to build webservices
[INFO] Kill Bill xml utils for loading jaxb xml object tree
[INFO] Kill Bill Automaton (state machines automaton)
  • ❤️1
xsalefter commented

As PRs for xmlloader and automaton merged, all spotbugs issue in this repository already fixed.