killbill/killbill-commons

Reaper over-reporting late entries

pierre opened this issue · 3 comments

pierre commented

We shouldn't call addAll in the for loop:

killbill-commons/queue/src/main/java/org/killbill/queue/DBBackedQueue.java

Line 298 in a152b9f

lateEntries.addAll(entriesLeftBehind);

kuguobing commented

for version 0.24.21 (0.24.*), need to fix also @xsalefter @pierre

xsalefter commented

Hi @kuguobing unfortunately, we won't backport this into 0.24.x. My only suggestion is that you update Kill Kill version to latest version. Or, if you just use killbill-commons version and not Kill Bill, you should able to update killbill-commons into latest version as well.

xsalefter commented

As this issue fixed in main branch, I'll close this issue.