Should `pokemaster.database` be private?
Opened this issue · 1 comments
I use a centralized pokemaster.database to manage all the query functions. But I think all functions in pokemaster.database should not be used by the end users directly. Hence, in the most recent commit 586d8ca, I've made it a private module, but I'm not entirely sure about this change.
Making pokemaster.database a private module makes perfect sense. The only thing the end users should use is really just pokemaster.Pokemon. The end users should not worry about all the SQLAlchemy tables under the hood. Only the vanilla Python types should be used as the arguments for the public APIs.
If there is no downside of having the module to be private, I'll include this change in release v0.1.
Also, if pokemaster.database is private, should it be tested (I don't think so)?