kirby561/CryptoRetriever

Crash on some datasets in DatasetViewer

Closed this issue · 1 comments

I get a crash when I load the attached ravencoin dataset (zipped) at the following in GraphRenderer.cs:
image

It happens every time
CoinGecko_Ravencoin_from_2-1-2022.zip

Fix delivered to master.

The issue was that 0 is not a day so when the requested granularity for the ticks was Months, it would create a DateTime with day 0, which would crash. I made it 1.

Commit
commit e78fa09
Author: Alex Hunt alexanderthunt@gmail.com
Date: Wed Apr 6 21:49:11 2022 -0400

Issue42: Fixed crash in DatasetViewer for some datasets.

Testing

  1. Opened the dataset in the description of the issue and verified it no longer crashes and properly displays the tickmarks.
  2. Opened a few other datasets and regression tested/made sure the tick marks are correct on those.