[Enhancement] Add min-width to chip in Segmented Control compact mode
Opened this issue · 5 comments
- I have written a good issue
Describe the bug
The small chip is not circular. There is 1px difference in the ratio.
Describe how to reproduce the bug
What was the expected behavior?
Add any screenshots
Please complete the following information:
- OS: [e.g. Windows, MacOS, iOS]
- Browser [e.g. Chrome, Safari]
- Browser version [e.g. 22]
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Verification
To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.
- Make sure the
NOT verifiedlabel has been removed by a member of team Kirby; do not proceed until this is done.
Implementation
The contributor who wants to implement this issue should:
- Make sure you have read: "Before you get coding".
- Signal to others you are working on the issue by assigning yourself.
- Create a branch from the develop branch following our branch naming convention.
- Create a test that reproduces the bug following guidelines in: "The good: Test".
- Write code to fix the bug
Review
Once the issue has been implemented and is ready for review:
- Do a self-review.
- Create a pull-request.
This is working as intended, as the chips width is dependent on its content. So for instance, with my selected text size in the browser this chip will be round:
While this will not:
If the segmented control should support circular chips, please consider submitting an enhancement.
Reopening as a request for added functionality to the chip, as this is not a bug.
Design spec on minimum width.
This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.