kirbyzone/sitemapper

Cannot change language

mynameisfreedom opened this issue · 5 comments

mynameisfreedom commented

Hi there! Thank you the beautiful plugin.
But there is an issue that language cannot be changed while this plugin is there.

The fix is to change line 23 in index.php from

'title' => site()->title() . ' Sitemap',

to

'title' => 'Sitemap',

squareclouds commented

thank you @mynameisfreedom !!! i just realized the site.yml was having trouble (everything else was fine, at least on my installation) and it is fixed after this.

  • 👍1
moritzebeling commented

I can confirm, when the plugin is installed in a multilang Kirby setup:

  • that the primary language can be edited as usual
  • content in secondary languages can be entered and saved (correct data is stored in content txt file)
  • but when panel is reloaded, the content is overwritten by the first lang value
moritzebeling commented

I can also confirm, that the suggested fix works. I am opening a PR...

moritzebeling commented

Please consider merging it or changing it on your own. Thank you!

iamlinkus commented

I can confirm. Just spent 2 hours trying to debug both my own code and kirby code until I remembered to try and remove sitemapper.

Looks like sitemapper isn't at all friendly with multilang setups as my site content was behaving super unexpectedly (switching languages on the panel always loaded only the default language content) and I never imagined that this plugin might bug the hell out of all the stuff that's not even related to the sitemap.

Thanks @moritzebeling for the quick fix. I wish I could help and fix this bug while retaining the full site title, but hopefully someone will. :)

  • 👍1