Feature Request: If picture is smaller than requested output do not scale up

Question

Feature Request: If picture is smaller than requested output do not scale up

Opened this issue 5 years ago · 4 comments

If the source image has 500px width and the requested size is 1500px the image should not be upscaled?

Answer 1 · 2019-02-15T10:27:11.000Z

Background: It should not waste bandwidth. So maybe upscale the image but reduce in size by setting quality accordingly.

Answer 2 · 2019-02-15T10:39:21.000Z

I think upscaling is by design a bad choice.
If you request a size that does not exist you should get the smaller one.
If we want to be more exact that case should give a 404.

What do you think?

Answer 3 · 2019-02-15T14:56:41.000Z

Well from Frontend perspective you don't want to handle edge cases like this with extra logic.

If a 404 is returned you have to implement some logic to get a smaller picture or you won't show it to the user. Both degrade the user experience.

I am thinking about closing the issue, as there is no way to scale up (not changing the size) and keeping the quality.

Answer 4 · 2019-02-15T14:59:47.000Z

Leave it open. I will think about that. Maybe there is a smart solution.

…

________________________________ From: DanielHabenicht <notifications@github.com> Sent: Friday, February 15, 2019 3:56:42 PM To: kirkone/KK.AspNetCore.Images Cc: Kirsten Kluge; Comment Subject: Re: [kirkone/KK.AspNetCore.Images] Feature Request: If picture is smaller than requested output do not scale up (#4) Well from Frontend perspective you don't want to handle edge cases like this with extra logic. If a 404 is returned you have to implement some logic to get a smaller picture or you won't show it to the user. Both degrade the user experience. I am thinking about closing the issue, as there is no way to scale up (not changing the size) and keeping the quality. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APDB3r6INILCOLwDWKKdG5dudIXzlmOJks5vNsqqgaJpZM4a9XK1>.