v1.2.0 enters infinite loop

Question

RaduBerinde opened this issue 6 years ago · 3 comments

Running errcheck on the CockroachDB code.

With errcheck v1.1.0:

$ time ~/roach2/bin/errcheck -exclude pkg/testutils/lint/testdata/errcheck_excludes.txt ./pkg/...

real	0m7.966s
user	0m45.962s
sys	0m5.611s

With v1.2.0, the same command doesn't finish (I waited 10 minutes). I also notice that a single core is pinned at 100% while it's running.

Answer 1 · 2019-01-11T17:53:00.000Z

This was with go 1.10.

Answer 2 · 2019-01-11T22:41:42.000Z

Looks like it works fine with go 1.11. Possibly related to golang/go#29427

Answer 3 · 2020-06-20T01:43:43.000Z

Hmm, I guess we can chalk it up to that x/tools bug? We've since dropped support for that Go version, so I'll close this issue.