kitodo/kitodo-publication

Hardcoded base URL in Emails should be removed

Erikmitk opened this issue · 2 comments

Erikmitk commented

kitodo-publication/Classes/Services/Email/Notifier.php

Line 66 in 3749807

$args['###URL###'] = 'http://nbn-resolving.de/' . $mods->getQucosaUrn();

kitodo-publication/Classes/Services/Email/Notifier.php

Line 144 in 3749807

$args['###URL###'] = 'http://nbn-resolving.de/' . $mods->getQucosaUrn();

kitodo-publication/Classes/Plugins/RelatedListTool/RelatedListTool.php

Line 92 in 50ae565

'parameter' => 'http://nbn-resolving.de/' . $value['docId'],

claussni commented

This URL does not need to be generated. It's there for historical reasons. Better to use the marker ###URN### and generate a proper HTML Link.

  • 👍1
Erikmitk commented

Yes, but the RelatedListTool-plugin only need the additional s. That has nothing to do with the Emails.