push latest Hackage version 0.2.1 to this git repo

Question

push latest Hackage version 0.2.1 to this git repo

Closed this issue 4 years ago · 12 comments

https://hackage.haskell.org/package/cmark-gfm-0.2.1 whereas this repo is still version 0.2.0.

Answer 1 · 2020-09-15T14:27:19.000Z

See also GHSA-7gc6-9qr5-hc85
(I can submit a patch of the github/cmark-gfm C changes if it helps, which I prepared for Fedora.)

Answer 2 · 2020-09-16T01:37:30.000Z

Ah, it was tagged but not on master somehow. Will fixup.

Answer 3 · 2020-09-16T01:43:04.000Z

I'll publish 0.2.2 shortly with the table fixup. Thanks for letting me know.

Answer 4 · 2020-09-16T01:59:21.000Z

0.2.2 has been released and is on Hackage.

Answer 5 · 2020-09-16T15:35:27.000Z

Thanks a lot!

Answer 6 · 2020-09-22T16:36:59.000Z

Asherah, do you know how to reproduce the O(n^2) table issue with pandoc?
So far I couldn't but I am not sure if I am using the right/needed gfm extensions etc.

I tried python -c 'print("aaa\rbbb\n-\v\n" * 30000)' | time pandoc -f gfm but that only takes ~7s on my laptop.
Whereas the corresponding pathological test takes >60s with cmark-gfm-0.29.0.gfm.0.

cc @jgm

edit: I tried now with gfm+pipe_tables too.

Answer 7 · 2020-09-22T16:44:48.000Z

pandoc doesn't use this library any more -- we use commonmark, commonmark-extensions, commonmark-pandoc.
(Assuming you're using recent pandoc)

Answer 8 · 2020-09-22T16:49:27.000Z

I know John, we communicated in email too recently.
But I am trying to reproduce this with pandoc-2.9 and earlier, thanks!

Answer 9 · 2020-09-23T04:17:59.000Z

Asherah, do you know how to reproduce the O(n^2) table issue with pandoc?

Unfortunately I have no experience with pandoc!

Answer 10 · 2020-09-23T10:18:41.000Z

Okay I was starting to wonder if even cmark-gfm-hs is directly affected or not?

I will try to make some test to see about that.

Answer 11 · 2020-09-23T15:29:07.000Z

Okay I can reproduce pretty easily for 0.2.1 with

commonmarkToHtml [] [extTable] (T.replicate 30000 "aaa\rbbb\n-\v\n")

inside test-cmark.hs

Answer 12 · 2021-02-01T06:59:06.000Z

Just FYI I did manage in the end recently to reproduce this also with pandoc in ghci at least:

:set -XOverloadedStrings
import qualified Data.Text as T
runPure $ readCommonMark (def {readerExtensions = githubMarkdownExtensions }) (T.replicate 3000 "aaa\rbbb\n-\v\n")

But afaict the pandoc program's preprocessing filters out the '\r' before it reaches readCommonMark, so it might not be affected?