kiwicom/orbit

Prohibit usage of global React Flow types (e.g. React$Node)

silvenon opened this issue · 1 comments

Global React Flow types are never mentioned in the Flow documentation, which strongly suggests that they don't like people using them. Also, using them in Orbit apparently caused some problems for others, so we should definitely stop using them and prohibit their usage via ESLint. However, I'm not aware of any ESLint rule that can do this, maybe there is one, I haven't thoroughly checked, but in case there isn't it should this is a great opportunity to learn how to build one because as far as complexity goes, this should be one of the simpler ones. ESLint has great documentation for working with rules and testing them, and AST explorer is your friend here.

sampi commented

I'll take this real quick ;)