[fluentd-elasticsearch] please add resources for awsSigningSidecar container
Closed this issue · 2 comments
esteban1983cl commented
Is this a request for help?:
yes
Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST
Version of Helm and Kubernetes:
HELM:
# helm version
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
# kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T12:36:28Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.10-eks-825e5d", GitCommit:"825e5de08cb05714f9b224cd6c47d9514df1d1a7", GitTreeState:"clean", BuildDate:"2019-08-18T03:58:32Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Which chart in which version:
latest and all versions
What happened:
When run kube-advisor, container fluentd-elasticsearch-aws-es-proxy is reported without cpu and memory resources and limits. Example:
+--------------------------+------------------------------------------------------+----------------------+-------------------------------------+ +
| logging | fluentd-elasticsearch-2cpp6 | 7543584n / 144876Ki | fluentd-elasticsearch-aws-es-proxy | |
+ + + + +--------------------------------+
| | | | | Memory Resource Limits Missing |
+ + + + +--------------------------------+
| | | | | CPU Request Limits Missing |
+ + + + +--------------------------------+
| | | | | Memory Request Limits Missing |
+ +------------------------------------------------------+----------------------+ +--------------------------------+
What you expected to happen:
Please add support in chart to assign it. For instance:
awsSigningSidecar:
enabled: false
image:
repository: abutaha/aws-es-proxy
tag: 0.9
resources:
requests:
cpu: 50m
memory: 40Mi
limits:
cpu: 100m
memory: 80Mi
How to reproduce it (as minimally and precisely as possible):
Run kube-advisor any cluster with fluentd-elasticsearch installed https://github.com/Azure/kube-advisor
Anything else we need to know:
Nothing else, thanks for your support.
monotek commented
PR welcome ;-)