kiwix/kiwix-desktop

Crash if Xapian triggers an exception

kelson42 opened this issue · 2 comments

kelson42 commented

I have such a crash scenario by running a search with a corrupted ZIM files with dev version of Kiwix Desktop on Linux:

Handling request QUrl("zim://fe516a05-6c7a-38ce-8ef6-1fdeecbb8f3d.search?content=fe516a05-6c7a-38ce-8ef6-1fdeecbb8f3d&pattern=paris ")
terminate called after throwing an instance of 'Xapian::DatabaseCorruptError'
Aborted (core dumped)

Kiwix should not crash in such a scenario but print a proper error like Kiwix Serve:
image

We should do this proper error handling for Xapian based suggestions as well (if not already done).

See also kiwix/kiwix-apple#622

kelson42 commented

@veloman-yunkan It seem nothing might have to be done here, see openzim/libzim#870 (comment). Please confirm then so we can close this ticket.

veloman-yunkan commented

@kelson42 I provided a fix that works with the current code and will keep working after the proposed fix is implemented in libzim.

  • 👍1