Compile without warnings

Question

Closed this issue 6 months ago · 7 comments

Kiwix should be able to compile without warnings. Once achieved we should put proper compiler options to report any warning in error.

Answer 1 · 2024-05-25T15:56:57.000Z

@ShaopengLin until PR review moves forward, can you move on this issue?

Answer 2 · 2024-05-29T07:15:44.000Z

@kelson42 I am having a hard time getting the build system working on Windows. Is there any documented step on it?

Answer 3 · 2024-05-29T07:44:07.000Z

@ShaopengLin Yes, not easy and this even changing currently. Please tackle the provlem on linux first.

Answer 4 · 2024-05-29T16:10:35.000Z

@kelson42 Maybe I missed some details, but we are already treating warnings as errors in Linux. #1085 seems to be a Windows-specific problem.

Answer 5 · 2024-05-30T05:03:40.000Z

I will check again but as I have open the issue, the compilation had warning on Linux so the acI was not failing because of this.

Answer 6 · 2024-05-31T08:12:44.000Z

Any updates? I cannot observe any warnings other than on Qt 5.12.8, where the warnings are rather, from Qt source code.

Answer 7 · 2024-05-31T08:18:19.000Z

Ok, then closing for the moment and will reopen when Insee a warning in the CI.