Remove autobind-decorator

Question

Remove autobind-decorator

Closed this issue 8 years ago · 6 comments

Please remove the autobind-decorator from the dependencies. Instead simply use the following in the constructor:
this.getStateFromProps = this.getStateFromProps.bind(this)

If you don't like this please set it at least as a dependency and not as a dev dependency. Currently it triggers an exception and requires a manual installation of autobind-decorator.

Answer 1 · 2016-09-13T14:35:37.000Z

I agree. Do you mind submitting a PR?

Answer 2 · 2016-09-13T14:49:07.000Z

Great!
Please see: #27

Answer 3 · 2016-09-13T14:52:19.000Z

On second thought, you shouldn't need autobind-decorator as a dependency.. (I could be wrong)

Answer 4 · 2016-09-13T14:53:08.000Z

@kjanoudi thoughts?

Answer 5 · 2016-09-13T14:53:28.000Z

At least the dist version on npm contains this:

var _autobindDecorator = require('autobind-decorator');

This is obviously not installed because it is a dev dependency.

Answer 6 · 2016-09-13T14:54:04.000Z

Yeah, you're totally right.