kkrt-labs/kakarot-ssj

feat: check starknet caller of `register_account` function

Opened this issue · 0 comments

Enable these two lines:

//TODO: enable this assertion. Will require changing test runner to snfoundry
// assert!(starknet_address == caller, "Account must be registered by the caller");

You will need to fix the tests:

    contracts_tests::test_kakarot_core::test_eth_call
    contracts_tests::test_account_contract::test_ca_external_starknet_call_native_token
    contracts_tests::test_account_contract::test_get_evm_address
    contracts_tests::test_account_contract::test_ca_bytecode
    contracts_tests::test_kakarot_core::test_eth_send_transaction_deploy_tx
    contracts_tests::test_account_contract::test_ca_get_nonce
    contracts_tests::test_kakarot_core::test_eth_send_transaction_non_deploy_tx
    contracts_tests::test_account_contract::test_ca_storage
    contracts_tests::test_kakarot_core::test_kakarot_core_compute_starknet_address
    contracts_tests::test_account_contract::test_ca_deploy
    contracts_tests::test_kakarot_core::test_kakarot_core_eoa_mapping
    contracts_tests::test_execution_from_outside::test_execute_from_outside_should_fail_account_with_code
    contracts_tests::test_account_contract::test_ca_external_starknet_call_cannot_call_kakarot_other_selector
    contracts_tests::test_kakarot_core::test_kakarot_core_deploy_eoa
    contracts_tests::test_execution_from_outside::test_execute_from_outside_eip_2930_counter_inc_tx
    contracts_tests::test_account_contract::test_ca_external_starknet_call_kakarot_get_starknet_address

Currently failing because of "Account must be registered by the caller"