klept0/MS-Rewards-Farmer

Migration away from selenium-wire to "nodriver"

Opened this issue · 10 comments

Selenium-wire has been archived:
https://github.com/wkeeling/selenium-wire

Selenium Wire is no longer being maintained. Thank you for your support and all your contributions.

There seems to be a complete replacement for selenium + selenium-wire + undetected-chromedriver:
https://github.com/ultrafunkamsterdam/nodriver

Ha this is what he had been working on and why UD Chromedriver was being neglected. I would like to get this tested and swap over so it alleviates some of the crashing errors we are getting with UD driver. I assigned us and if we would like to get some form of chat going feel free to suggest - I have TG/Discord etc

still relevant

@klept0 id highly suggest checking out selenium base as well while you’re considering migration.

There are a lot of quality of life features baked in that make developing selenium apps much more pleasant. as an example, every command (find, click, etc) automatically has the web driver wait built in so you don’t have to write it every time.

https://seleniumbase.io/help_docs/uc_mode/

cal4 commented

Yeah, I've attempted to get rid of https://github.com/ultrafunkamsterdam/undetected-chromedriver if for anything else it seems like pretty crappy code (see how quit and close doesn't work).

Granted this dependency is inherited from https://github.com/charlesbel/Microsoft-Rewards-Farmer/blob/master/requirements.txt, it would be nice exploring if we can just get rid of it altogether. Or at the least come up with a use case where vanilla Selenium doesn't work (or causes trouble).

100% for a migration away from it - have not had the time for a dedicated period to sit and see where the specifics from the UD-CD are to remove/replace and get this integrated.

Hi is there anyway I can help with migrating to nodriver? I've never used nodriver but I think I have the time to learn it and make a contribution in someway or another.

cal4 commented

@HaveSomeRubicon think the plan is to move away from nodriver/undetected chromedriver/selenium wire and to just using plain ole vanilla selenium (until proven otherwise). See #161 (comment).

If you'd like to contribute though, feel to fork try removing these dependencies, or feel free to pick up any of the other enhancements.

not stale :p

yeah Im fixing that - ignore the message

@MeetBhingradiya seems unrelated and nonsensical