Containerize app and add CI
Opened this issue · 5 comments
Is your feature request related to a problem? Please describe.
Different environments (Windows/Linux/Mac, Python versions), could contribute to different behavior which makes development tougher
Describe the solution you'd like
A containerized app and CI pipeline to build images
Additional context
Personally I just run this app via Python directly. So far haven't noticed too many it worked on my box issues (with exception of #137 (comment)). Even if we move to container, will people run it that way or just use Python directly? Work started in #114.
I run it in a container at the moment, but in a glued together way. Would make things easier and faster to implement so I definitely would appreciate an official approach.
I created a home assistant addon, which is basically a Dockerfile. You can see it here:
https://github.com/jdeath/homeassistant-addons/tree/main/msrewardsfarmer it largely stole from LtCMDstone docker image.
An official docker image would be nice. I would suggest it just wrap the python code and not try jam in cron. You can see in my version all the seds I had to do to make load the config files and output the log from the current directory, versus the installed location. I also had to add some extra wait times and remove the webdriver.close() calls to avoid crashes. I tried using chromium, but it did not complete searches, so stuck with official chrome deb as I run on x86. Anyways, maybe this will help.
This issue is stale because it has been open for 14 days with no activity.
This issue was closed because it has been inactive for 7 days since being marked as stale.
Suggestion
- Create a docker guide to use the docker component of the dev branch