kleros/kleros-interaction

Redefinition of MetaEvidence and other events

Closed this issue · 3 comments

Part of #243 (bounty)

/** @dev To be emitted when meta-evidence is submitted.
* @param _metaEvidenceID Unique identifier of meta-evidence. Should be the `transactionID`.
* @param _evidence A link to the meta-evidence JSON that follows the ERC 1497 Evidence standard (https://github.com/ethereum/EIPs/issues/1497).
*/
event MetaEvidence(uint indexed _metaEvidenceID, string _evidence);

contract MultipleArbitrableTransaction is IArbitrable {

/** @dev To be emmited when meta-evidence is submitted.
* @param _metaEvidenceID Unique identifier of meta-evidence.
* @param _evidence A link to the meta-evidence JSON.
*/
event MetaEvidence(uint indexed _metaEvidenceID, string _evidence);

What do we need to redefine?

I think quite the opposite.

I think there is a duplication.

Event is defined twice.

Both in the IArbitrable.sol and the re-redefined in MultipleArbitrableTransaction.sol

Events are inherited: https://ethereum.stackexchange.com/questions/34666/are-events-not-inherited-in-solidity

Yeah, it is forgotten.