kleros/kleros-interaction

Consistently emit Payment events

Closed this issue · 3 comments

marsrobertson commented

kleros-interaction/contracts/standard/arbitration/MultipleArbitrableTransaction.sol

Line 152 in bb41ba3

emit Payment(_transactionID, _amount, msg.sender);

kleros-interaction/contracts/standard/arbitration/MultipleArbitrableTransaction.sol

Line 167 in bb41ba3

emit Payment(_transactionID, _amountReimbursed, msg.sender);

Here there is no Payment event:

kleros-interaction/contracts/standard/arbitration/MultipleArbitrableTransaction.sol

Line 181 in bb41ba3

transaction.status = Status.Resolved;

0xferit commented

kleros-interaction/contracts/standard/arbitration/MultipleArbitrableTransaction.sol

Line 57 in bb41ba3

/** @dev To be emitted when a party pays or reimburses the other.

marsrobertson commented

HMMM... Executing a transaction does not emit any events.

0xferit commented

I agree that event name is a bit misleading. But the intention is to use it for pay and reimburse functions.