[1.21][NeoForge] Bound books not generating names
ffuentesm opened this issue · 2 comments
Describe the bug
Bound books have no names when crafted
To Reproduce
Steps to reproduce the behavior:
- craft a spirit book
- bind it
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
System (please complete the following information):
- Occultism Version: occultism-1.21-neoforge-1.139.2
Additional context
I have Inventory profile Next for fast crafting, but I don't think that is affecting it.
@ffuentesm can you try this in an occultism-only (+ jei/emi if needed) environment (no fast crafting)?
I just tested this with a simple curseforge 1.21 profile with just occultism, and the moment I actually take the result book from the crafting grid, I get a name.
This is expected behaviour in 1.21 due to the changes to nbt/components and when I can safely initialize them.
Maybe fast craft skips the "onCrafted" call which I use to set the data?
If that is the case we would have to ask them what better way there is to do that and still be compatible with them
I just re started the game.
I tried crafting it manually without changing anything. It generated a name.
I also tried the fast crafting, and it worked.
No idea what happened.