klikli-dev/theurgy

Rendering issue with the sal tank and accumulator

Closed this issue · 5 comments

The sal tank / accumulator multiblock is rendering its fluid contents offset from the block, causing it to protrude outside the tank/accumulator model.

To Reproduce

  1. Fresh install on minecraft 1.20.1
  2. Place down a sal tank / accumulator to form the multiblock
  3. Right click with a bucket of water to add it to the tank.

Expected behavior
Correct rendering of the tank contents.

Screenshots
2023-10-26_16 23 56

System (please complete the following information):

  • Theurgy Version: theurgy-1.20.1-1.7.0.jar
  • OS: Windows
  • Minecraft Version: 1.20.1
  • Modpack Link and Version, or list of mods: fresh install with nothing but Theurgy and Occultism (and required dependencies). Forge 47.2.1

@RAldrich thank you for reporting! I've seen this issue before but couldn't reproduce it (Will try again!).
Out of interest are you using an nvidia or amd (or intel) graphics card?
Trying to figure out what may influence the rendering beyond the mods as you have only the minimum

I'm experiencing the same rendering issue (though I do have more mods than just Theurgy). I'm using Theurgy 1.20.1-1.7.0 with Forge 47.2.1, on a NVIDIA GPU.

Thank you! I will try - I think it might be the forge version because I never tried beyond 47.1.3 which is the one compatible with neoforge, I will try with both now to see

EDIT: managed to reproduce it on 47.1.3 when running on curseforge. Weirdly enough when using the same setup in my dev env it works .. now time to dig in

EDIT: Yup .. if I make it intentionally render wrong in dev it renders correct in game .. what a weird thing

Please ping me in case 1.7.1 does not fix this for you, or actually causes it for you.

Hey sorry, didn't see your question until after you'd already merged the fix! I have an AMD GPU. I was also running it from the Curseforge launcher.

That said, your fix did in fact fix it for me! Bizarre that it would render differently in dev vs prod, but hey, one more point for pre-prod test envs.

Thanks for the rapid fix!