klippa-app/nativescript-login

Facebook login on Android results in error message about login on embedded browsers being disabled

kajic opened this issue · 5 comments

Hi, thanks for the report! I think this happens when use user doesn't have the Facebook app installed. It was already on my to-do list to upgrade the native SDK's, but I'll move it forward to do it asap.

kajic commented

I see. We were able to fix it by creating a App_Resources/Android/gradle.properties file with
facebookSDKVersion=12.0.0 in it. I did have the Facebook app installed though, so I suppose that's a somewhat separate issue.

And thank you for this lib. Very useful!

That's odd, did not experience the issue myself when having the app installed.
I'm currently upgrading the SDK's on all platforms in this branch: https://github.com/klippa-app/nativescript-login/tree/feature/upgrade-sdks

Only one left is Google Sign iOS SDK v6, but thats almost complete. I'm trying to release it in the coming days.

Please note that you will have to adjust your Android Manifest.xml a littlebit to fully support it, see the updated readme in the branch:
https://github.com/klippa-app/nativescript-login/blob/feature/upgrade-sdks/README.md#android-integration

You have to add the two Facebook activities to fully support the Chrome tabs to make login work when users don't have the Facebook app installed. This is the method that they are using since they disabled webviews.

kajic commented

I tried uninstalling the Facebook app and the login still works on FB SDK 12. It looks like the SDK now opens Facebook's login webpage in something that perhaps doesn't count as an embedded browser.

So I think it should all be resolved by updating the required SDK version.

Fixed in version 3.1.0, 2.1.0 and 1.2.0 :)
Google Sign iOS SDK v6 update is not released yet, see #35