kmagiera/babel-watch

Degradation after refactoring and another uncaught error location

Closed this issue · 4 comments

IMalyugin commented

Last commit introduced a degradation here:
e8e60af#diff-3ff4a3ee3a0bfeb4fbf652e6a71273903130d817040ffac875ac6540b98e5907R438

If files are ignored (aka no source) we should still send it the runner, so they can be handled by defaultLoader.
With this new line, babel-watch refuses to require .json files.

There is yet another issue I found, that is unrelated to both last feature and refactoring. During babel compilation, only syntax errors are caught. Any other thrown error is typically ignored. Problem is that require.ext just causes an exception and it becomes unhandled.

Got both fixes ready in a pull request

@STRML ping

STRML commented

Thanks for finding, will merge & release after testing

IMalyugin commented

Works for me, launching an entire server:

  • restart on change
  • .json files
  • exceptions during execution

Although i think i have double errors during restart, gotta double check

STRML commented

I was getting double errors before this PR but now I'm actually getting obfuscation of the old error. I don't think it's good to introduce an uncaughtException error here as it will essentially leak into user code. Will fix.

IMalyugin commented

We could just capture and log error from require[ext].

As for the double error - nevermind, I'm getting it regardless.