kmck/react-hex-editor

Is necessary this children?

macabeus opened this issue · 1 comments

macabeus commented

I'm reading the code source of this package, and I noticed that HexEditorBody could receive a children and render that. But I can't understand very well how it could be useful.

I think that we could remove this line:

react-hex-editor/src/components/HexEditor.tsx

Line 857 in ac62946

{children}

And removing that, we are able to remove too the component HexEditorBody, that its only purpose is handle this possible children.

kmck commented

this allows the addition of other components alongside the hex editor data view. i added it to support custom data visualization (rather than just ascii), such as interpreting the value as image data and rendering to canvas.

this isn't particularly well documented, so i can understand why you'd be curious about it!

  • 👍1