As a Kperf developer, I want to refine service generate/measure flags, code comments and etc.
zhanggbj opened this issue · 4 comments
Refine service generate and measure
- CLI flags
Per offline discussion with @qibobo who is working on refining, this Issue will also cover
- Add more code comment
As suggested #3 (comment)
- Variable definition
As commented https://github.com/knative-sandbox/kperf/pull/3/files#r509885363
https://github.com/knative-sandbox/kperf/pull/3/files#r509885434, good to add a common function.
@zhanggbj: GitHub didn't allow me to assign the following users: qibobo.
Note that only knative-sandbox members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide
In response to this:
/assign @qibobo
Yang is helping with this. Thanks!
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
PR merged. Close it.