Change client.go's `subscription` to better reflect the Trigger Filter attributes

Question

Change client.go's `subscription` to better reflect the Trigger Filter attributes

matzew opened this issue 5 months ago · 3 comments

Currently the client.go file contains a Subscription:

type Subscription struct {
	Source string `json:"source" yaml:"source"`
	Type   string `json:"type" yaml:"type"`
	Broker string `json:"broker" yaml:"broker"`
}

This struct is wrong, since it only represents the source and/or type attributes on the Trigger.Filter, however that can be anything, no requirement on source or type as a criteria.

Answer 1 · 2024-01-18T09:25:23.000Z

See also knative/eventing#7265

Answer 2 · 2024-01-18T10:30:56.000Z

It would be nice, if for func describe things would render like:

Subscriptions (Broker and Attributes):
  my-broker, map[source:/something type:org.apache.camel.event.aws.s3.getObject extension:someOther]

Answer 3 · 2024-04-18T01:23:04.000Z

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.