Path handling works only for linux-style "/" separator

Question

Path handling works only for linux-style "/" separator

Closed this issue 10 years ago · 4 comments

orenshatz commented 10 years ago

Windows path ("/" separated) are completely not taken into account.

Answer 1 · 2015-05-19T11:57:19.000Z

You know windows supports both?

Answer 2 · 2015-05-19T12:00:21.000Z

Windows supports both, but our code currently doesn't supports Windows.

Answer 3 · 2015-05-19T12:02:08.000Z

It's not even fully supported on Windows, try "dir c:/temp/" on command line.

Answer 4 · 2015-05-19T13:34:00.000Z

The current bug was that glob.glob returns a backslash on Windows, while the code expects hard-coded forward slash everywhere.
For now I solve the problem by replacing the OS path separator with a hard-coded forward-slash.
The current long-term solution is just to keep using hard-coded forward-slash everywhere, and treat each backward-slash case (as above) adequately.
The user is therefore also expected to pass only forward-slashed paths to DatasetUtils. I documented this in the function docs.