Why do elli depend on inets?

Question

Why do elli depend on inets?

Closed this issue 5 years ago · 3 comments

Elli starts inets if you run application:ensure_all_started(elli), yet inets isn't used anywhere.

Answer 1 · 2017-12-07T10:09:32.000Z

Hi, Elli uses http_uri:decode/1 which is a part of inets. http_uri:decode/1 does not rely on the inets application being started so one could argue that it should be moved to included_applications. Would that work for you?

Answer 2 · 2017-12-07T12:44:04.000Z

True, didn't think to check for that. That solution absolutely works for me in the short run. 👍

I just can't help the feeling that it is kind of dirty to pull in a library containing another full http-server, http-client and ftp-client, just to call the one function. Have you considered just copying that function into elli or write your own version? Would be happy to supply a PR if you want to outsource that. :)

Answer 3 · 2017-12-13T00:25:52.000Z

Yeah, we'll happily take a PR for that :)

…

On Thu, Dec 7, 2017 at 4:44 AM, Christoffer Vikström < ***@***.***> wrote: True, didn't think to check for that. That solution absolutely works for me in the short run. I just can't help the feeling that it is kind of dirty to pull in a library containing another full http-server, http-client and ftp-client, just to call the one function. Have you considered just copying that function into elli or write your own version? Would be happy to supply a PR if you want to outsource that. :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#109 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWPxMlkJ5z7KaeRI3mRmNkrgHW_spaiks5s992VgaJpZM4Q4qDY> .