custom_event_logging busted?
Closed this issue · 1 comments
lamont-granquist commented
I'm not seeing any custom events showing up in the logfile.
In your test specs there's also clearly an issue where you only assert the format of the custom event line, you don't assert that there must be a line present which is a custom event:
gc_tracer/spec/gc_tracer_spec.rb
Lines 93 to 95 in 01aa824
If no line matches /out/ then your specs will still pass.
lamont-granquist commented
Nevermind, think I was looking at an old log file somehow, and didn't quite get enough sleep last night...