koajs/compress

duplicate logic

tj opened this issue · 4 comments

tj commented

maybe you have some ideas on this, but I'd definitely like if we didn't have to shadow the default stuff in Koa for these kinds of middleware, it'll definitely become error-prone (and just not fun to work with). Thankfully I don't think too many will sit "under" like this one does, it was a decent PITA with connect as well, but maybe we can work on improving that.

agreed. that's why i preferred if it were in core, even if it's disabled by default, as it's easier.

tj commented

I just think if we keep sticking things in there we've definitely messed up the api

i agree with that too! we'll just have to see

it's pretty good now