Upgrade redis to v2.5

Question

Upgrade redis to v2.5

ratson opened this issue 9 years ago · 5 comments

Some features are deprecating for v3.

Answer 1 · 2016-03-16T16:08:00.000Z

PR's welcome!

Answer 2 · 2016-03-16T17:30:06.000Z

We'll need to update the tests to explictely provide the flush argument to the end() function. See the deprecation section here: https://github.com/NodeRedis/node_redis/releases/tag/2.5.0-1.

Answer 3 · 2016-03-16T17:35:20.000Z

I created a new branch to test the update. The tests passed, but there are lots of warnings that need to be resolved: https://travis-ci.org/koajs/koa-redis/jobs/116438808. I can look into them by the end of the week, but a PR is welcome.

These are the two warnings:

The drain event listener is deprecated and will be removed in v.3.0.0.
If you want to keep on listening to this event please listen to the stream drain event directly.

The idle event listener is deprecated and will likely be removed in v.3.0.0.
If you rely on this feature please open a new ticket in node_redis with your use case

Answer 4 · 2016-05-19T04:07:27.000Z

Updated in 16bfa02.

Answer 5 · 2016-05-19T04:11:14.000Z

Released version 2.1.0 with this improvement.