koalalorenzo/python-digitalocean

Domain.create_new_domain_record ttl kwarg is ignored

alexzorin opened this issue · 1 comments

Hi,

In create_new_domain_record, this package is overriding the ttl kwarg, which comes from the domain's overall TTL (from SOA):

if self.ttl:
data['ttl'] = self.ttl

which is populated earlier here:

def load(self):
# URL https://api.digitalocean.com/v2/domains
domains = self.get_data("domains/%s" % self.name)
domain = domains['domain']
for attr in domain.keys():
setattr(self, attr, domain[attr])

Consequently, the ttl kwarg is ignored.

This affects certbot/certbot#9149.

Closing for inactivity! Feel free to comment or open a new one if needed!