koderover/zadig

zadig failed to synchronize the git helm repository [bug]

llussy opened this issue · 7 comments

llussy commented

What happened?

I delete the serviceaccount.yaml file in the git repository，on zadig web resync, serviceaccount.yaml persist。

What did you expect to happen?

On zadig web resync.

image

Web view serviceaccount.yaml is gone, but it is still there after synchronization

image

image

my helm git

image

https://gitee.com/llussy/helm/tree/master/web

Install Methods

  • Helm

Versions Used
zadig: zadig-1.18.0

kubernetes:
k3s v1.27.4

Services Status

# kubectl version
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4+k3s1", GitCommit:"36645e7311e9bdbbf2adb79ecd8bd68556bc86f6", GitTreeState:"clean", BuildDate:"2023-07-28T01:30:27Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4+k3s1", GitCommit:"36645e7311e9bdbbf2adb79ecd8bd68556bc86f6", GitTreeState:"clean", BuildDate:"2023-07-28T01:30:27Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}

# kubectl get pod
NAME                             READY   STATUS    RESTARTS      AGE
warpdrive-768cfd8f75-gfd4t       1/1     Running   0             20m
kr-minio-7766c7877f-6xjfw        1/1     Running   0             20m
discovery-6b64b69845-847ck       1/1     Running   0             20m
gloo-bf4d5c8df-mpxnd             1/1     Running   0             20m
zadig-portal-686bdbf96b-k766j    1/1     Running   0             20m
cron-5fd55765d6-6br4j            1/1     Running   0             20m
opa-68686dc95-7l4qx              1/1     Running   0             20m
gateway-proxy-595b4d87d4-fzl6x   1/1     Running   0             20m
warpdrive-768cfd8f75-n2djk       1/1     Running   0             20m
hub-server-569c84cf78-2grkp      1/1     Running   0             20m
gateway-6b9b544d6-j5rt4          1/1     Running   0             20m
kr-mysql-0                       1/1     Running   0             20m
dind-0                           1/1     Running   0             20m
kr-mongodb-0                     1/1     Running   0             20m
user-6568c47bc7-9v7mh            1/1     Running   2 (20m ago)   20m
aslan-8687b9cb86-kqcml           1/1     Running   2 (20m ago)   20m
zadig-dex-5b458794f5-tjw8k       1/1     Running   1 (20m ago)   20m
llussy commented

I modified value.yaml and it can be synchronized normally, but the deleted serviceaccout.yaml has always existed in zadig.

fansi404 commented

thanks for your feedback, for now, if you delete some files on git, how about delete the old service on Zadig, then add a new service ?

llussy commented

image

I deleted it in the service, and then added it again, but the serviceaccount.yaml file still exists.

fansi404 commented

for now the behavior meets the expectation: once the service was created, the original Helm Chart file was storaged in the default S3 system, so delete some files in Git repo makes no effect.

we will evaluate the reasonableness of such behavior

llussy commented

Seems unreasonable, when my git repository has wrong files（like hpa.yaml.swp,accidentally pushed him to the git repository）, after I delete it and resync, the redeploy will fail because he will read the abnormal files in S3.

deploy error message:
failed to upgrade helm chart test-env-dev/nginx: parse error at (nginx/templates/.hpa.yaml.swp:1): unexpected {{end}}

fansi404 commented

thanks for your feedback, it will be resolved in Zadig v1.19.0

lilianzhu commented

it has been resolved in Zadig