kohya-ss/sd-scripts

Always save network module type to metadata

space-nuko opened this issue · 4 comments

I'm thinking it would be a good idea to always save the network module type to the metadata because that allows the models list in additional_networks to be filtered based on that metadata. Without it it's too easy to choose a non-locon model

I think the metadata already has ss_network_module. Its value is like networks.lora.

Is this sufficient for filtering?

I mean to say to save it even if --no-metadata is passed on the command line. In practice some of the metadata like sshs_model_hash is useful for the additional_networks indexer also

I got it! I will save ss_network_module, ss_network_dim, ss_network_alpha and ss_network_args. These values can be determined the weights itself, it is not a problem if the metadata contains them.

Now minimum metadata is recorded. I will also work on the merged/extracted models.